Change KubeVirt VM CPU assignment to not overwrite cpu alloc ratio by soer3n · Pull Request #1906

Change KubeVirt VM CPU assignment to not overwrite cpu alloc ratio by soer3n · Pull Request #1906 · kubermatic/machine-controller

added release-note

Denotes a PR that will be considered when it comes time to generate release notes.

kind/chore

Updating grunt tasks etc; no production code changes.

docs/tbd

Denotes a PR that needs documentation (change) that will be done later.

dco-signoff: yes

Denotes that all commits in the pull request have the valid DCO signoff message.

sig/cluster-management

Denotes a PR or issue as being assigned to SIG Cluster Management.

size/S

Denotes a PR that changes 10-29 lines, ignoring generated files.

labels

Mar 10, 2025

Signed-off-by: soer3n <srenhenning@googlemail.com>

Signed-off-by: soer3n <srenhenning@googlemail.com>

kubermatic-bot added size/M

Denotes a PR that changes 30-99 lines, ignoring generated files.

and removed size/S

Denotes a PR that changes 10-29 lines, ignoring generated files.

labels

Mar 10, 2025

Signed-off-by: soer3n <srenhenning@googlemail.com>

kubermatic-bot added size/L

Denotes a PR that changes 100-499 lines, ignoring generated files.

docs/none

Denotes a PR that doesn't need documentation (changes).

and removed size/M

Denotes a PR that changes 30-99 lines, ignoring generated files.

docs/tbd

Denotes a PR that needs documentation (change) that will be done later.

labels

Mar 12, 2025

ahmedwaleedmalik changed the title ~~change kubevirt vm cpu assignment to not overwrite cpu alloc ratio~~ Dhange KubeVirt VM CPU assignment to not overwrite cpu alloc ratio

Mar 12, 2025

ahmedwaleedmalik changed the title ~~Dhange KubeVirt VM CPU assignment to not overwrite cpu alloc ratio~~ Change KubeVirt VM CPU assignment to not overwrite cpu alloc ratio

Mar 12, 2025

Signed-off-by: soer3n <srenhenning@googlemail.com>

* adapt kubevirt cpu struct for configuring vcpus for a virtual machine
* modify logic in function for rendering resource requests and limits
* modify validation accordingly to be a bit more specific regarding resources

Signed-off-by: soer3n <srenhenning@googlemail.com>

Signed-off-by: soer3n <srenhenning@googlemail.com>

Signed-off-by: soer3n <srenhenning@googlemail.com>

kubermatic-bot added the approved

Indicates a PR has been approved by an approver from all required OWNERS files.

label

Mar 14, 2025

soer3n added a commit to soer3n/machine-controller that referenced this pull request

Apr 4, 2025

…ubermatic#1906)

* change kubevirt vm cpu assignment to not overwrite cpu alloc ratio

Signed-off-by: soer3n <srenhenning@googlemail.com>

* update kubevirt testdata

Signed-off-by: soer3n <srenhenning@googlemail.com>

* revert testdata change and add condition for vm cpu assignment

Signed-off-by: soer3n <srenhenning@googlemail.com>

* switch to providerSpec for enabling vcpu assignment

Signed-off-by: soer3n <srenhenning@googlemail.com>

* adapt kubevirt cpu struct

* adapt kubevirt cpu struct for configuring vcpus for a virtual machine
* modify logic in function for rendering resource requests and limits
* modify validation accordingly to be a bit more specific regarding resources

Signed-off-by: soer3n <srenhenning@googlemail.com>

* revert unnessecarry changes to mocked kubevirt vm

Signed-off-by: soer3n <srenhenning@googlemail.com>

* changes after review

Signed-off-by: soer3n <srenhenning@googlemail.com>

---------

Signed-off-by: soer3n <srenhenning@googlemail.com>

soer3n added a commit to soer3n/machine-controller that referenced this pull request

Apr 4, 2025

…ubermatic#1906)

* change kubevirt vm cpu assignment to not overwrite cpu alloc ratio

Signed-off-by: soer3n <srenhenning@googlemail.com>

* update kubevirt testdata

Signed-off-by: soer3n <srenhenning@googlemail.com>

* revert testdata change and add condition for vm cpu assignment

Signed-off-by: soer3n <srenhenning@googlemail.com>

* switch to providerSpec for enabling vcpu assignment

Signed-off-by: soer3n <srenhenning@googlemail.com>

* adapt kubevirt cpu struct

* adapt kubevirt cpu struct for configuring vcpus for a virtual machine
* modify logic in function for rendering resource requests and limits
* modify validation accordingly to be a bit more specific regarding resources

Signed-off-by: soer3n <srenhenning@googlemail.com>

* revert unnessecarry changes to mocked kubevirt vm

Signed-off-by: soer3n <srenhenning@googlemail.com>

* changes after review

Signed-off-by: soer3n <srenhenning@googlemail.com>

---------

Signed-off-by: soer3n <srenhenning@googlemail.com>

kubermatic-bot pushed a commit that referenced this pull request

Apr 7, 2025

* Change KubeVirt VM CPU assignment to not overwrite cpu alloc ratio (#1906)

* change kubevirt vm cpu assignment to not overwrite cpu alloc ratio

Signed-off-by: soer3n <srenhenning@googlemail.com>

* update kubevirt testdata

Signed-off-by: soer3n <srenhenning@googlemail.com>

* revert testdata change and add condition for vm cpu assignment

Signed-off-by: soer3n <srenhenning@googlemail.com>

* switch to providerSpec for enabling vcpu assignment

Signed-off-by: soer3n <srenhenning@googlemail.com>

* adapt kubevirt cpu struct

* adapt kubevirt cpu struct for configuring vcpus for a virtual machine
* modify logic in function for rendering resource requests and limits
* modify validation accordingly to be a bit more specific regarding resources

Signed-off-by: soer3n <srenhenning@googlemail.com>

* revert unnessecarry changes to mocked kubevirt vm

Signed-off-by: soer3n <srenhenning@googlemail.com>

* changes after review

Signed-off-by: soer3n <srenhenning@googlemail.com>

---------

Signed-off-by: soer3n <srenhenning@googlemail.com>

* fix kubevirt cpu check + update sdk version in go.mod

Signed-off-by: soer3n <srenhenning@googlemail.com>

revert change regarding import of sdk submodule

Signed-off-by: soer3n <srenhenning@googlemail.com>

kubevirt resources and vcpus should only be parsed wihtout specified instance type

Signed-off-by: soer3n <srenhenning@googlemail.com>

---------

Signed-off-by: soer3n <srenhenning@googlemail.com>