Home Original page

fix minor unreachable code caused by t.Fatal by Abirdcfly · Pull Request #6283 · letsencrypt/boulder

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@Abirdcfly

Copy link Copy Markdown

Contributor

Signed-off-by: Abirdcfly fp544037857@gmail.com

@Abirdcfly Abirdcfly requested a review from a team as a code owner

August 10, 2022 07:48
Copy link Copy Markdown

Contributor

@aarongable aarongable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Rather than deleting this line, please move it above the t.Fatal() call.

@Abirdcfly

Copy link Copy Markdown

Contributor Author

Good catch! Rather than deleting this line, please move it above the t.Fatal() call.

Done. Thanks for review.

@Abirdcfly Abirdcfly changed the title delete minor unreachable code caused by t.Fatal fix minor unreachable code caused by t.Fatal

Aug 11, 2022 
Signed-off-by: Abirdcfly <fp544037857@gmail.com>

@aarongable aarongable merged commit 7cd35f4 into letsencrypt:main

Aug 12, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aarongable aarongable aarongable approved these changes

@beautifulentropy beautifulentropy beautifulentropy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Abirdcfly @aarongable @beautifulentropy