Add updatePushURLString:error: to GTRemote by Uncommon · Pull Request #585 · libgit2/objective-git

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@Uncommon

Copy link

Contributor

@Uncommon Uncommon commented

Jul 9, 2016

This is to match updateURLString:error:. There is a a setPushURLString: but it ignores errors.

At the moment I'm not able to run the tests (see #584) so I'm counting on Travis...

@pietbrauer pietbrauer mentioned this pull request

Jul 11, 2016

@Uncommon

Copy link

Contributor Author

Having resolved #584, I have successfully run the tests.

@pietbrauer pietbrauer merged commit 7febb4f into libgit2:master

Jul 13, 2016

@pietbrauer

Copy link

Member

Seems good, thanks! ✨

@Uncommon Uncommon deleted the updatepush branch

January 5, 2017 23:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Uncommon @pietbrauer