Wrap git_index_add_all by alehed · Pull Request #628 · libgit2/objective-git
Allows the user to do something like git add -A
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! Looks good at a first glance. Could you add some simple tests for this? You could copy one of the existing ones, just add more than 1 file to it.
Sure, I just thought the test suite is ignored on this project.
I look at it. We "just" have one failing test on macOS which is consistent 😆. iOS is a different story.
Yeah, would be great if all the tests worked... But I do too see the value in testing.
I'll probably get around to the tests this weekend.
Yeah, many people have spent many hours trying to fix the tests. Thanks a lot! No pressure from my side 😅
#599 has a green iOS build, but it is already 5 months old.
alehed
deleted the
index_add_all
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters