correctly create directory for path_outputs if not existing by mashb1t · Pull Request #1668 · lllyasviel/Fooocus

Skip to content

Navigation Menu

Sign in

Appearance settings

Conversation

@mashb1t

Closes #1077

Currently the config is loaded first and falls back to the default outputs dir if it doesn't exist, then creates the fallback outputs dir... which doesn't make that much sense to me.

Expected:

  1. change config path_outputs to non-existing directory
  2. run Fooocus
  3. path_outputs dir does get created

Actual

  1. change config path_outputs to non-existing directory
  2. run Fooocus
  3. loads config, doesn't find path_outputs dir,m falls back to default value
  4. calls os.makedirs(path_outputs, exist_ok=True) on fallback value
  5. path_outputs dir does not get created

@mashb1t mashb1t added the Size M

medium change, isolated, testing with care

label

Feb 9, 2024

@mashb1t mashb1t changed the base branch from main to develop

February 25, 2024 17:07
# Conflicts:
#	modules/config.py

Labels

Size M

medium change, isolated, testing with care

1 participant

@mashb1t