Home Original page

minor fix for duplicate legend entries for color ramp rasters by egouge · Pull Request #229 · locationtech/udig-platform

@egouge

@egouge 

…fferent font sizes

Signed-off-by: egouge <egouge@refractions.net>

@fgdrf fgdrf added this to the uDig-2.0.0 milestone

May 19, 2017

fgdrf

String l1 = entry.getLabel();
String l2 = prevEntry.getLabel();
if (i <= entries.length - 3){
if (i < entries.length - 1){

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@egouge I'm not sure what this if-Statement is for because in the else-block the first inner statement (l2 == null) looks pretty identical to the inner statement of that if.

Question : What's the reason/use-case that String[] text can have length of 1 or the length of two? I thought that a LegendEntry represents one line in the Legend with ImageDescriptor and text element. My understanding is that every entry should have a LegentEntry representation after iterations. The if-Statement looks like only for the last one merge the text of the previous and the current and make a new Entry out of it. Why has the last Entry an array lenght for text of two while all others have a lenght of one. What I did not understand?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: What's the reason/use-case that String[] text can have length of 1 or the length of two?
A: From what I remember - it was the only way I could "easily" get "gradient" styles to appear in the correctly without substantially rewriting other parts of the Legend Graphic.
In the case shown above there are four labels (0, 3, 6, 8) but in terms of the colors (and legend entries) there are only three: white to light green [0-3]; light green to medium green [3-6]; and medium green to dark green [6,8]. So in order to get all the labels to show up one of those three legend entries needed to have two labels.
I am sure there were other ways of doing this, but this is what I came up with at the time.

fgdrf

fgdrf previously requested changes May 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@egouge I'm not sure what this if-Statement is for because in the else-block the first inner statement (l2 == null) looks pretty identical to the inner statement of that if.

Question : What's the reason/use-case that String[] text can have length of 1 or the length of two? I thought that a LegendEntry represents one line in the Legend with ImageDescriptor and text element. My understanding is that every entry should have a LegentEntry representation after iterations. The if-Statement looks like only for the last one merge the text of the previous and the current and make a new Entry out of it. Why has the last Entry an array lenght for text of two while all others have a lenght of one. What I did not understand?

@fgdrf fgdrf dismissed their stale review

May 24, 2017 04:51

tested the review process and was trying to comment then requesting changes

@fgdrf

@egouge Thank you very much for the fix and the continuous support! Much appreciated