Home Original page

fix problem causing deadlock while copying features between the same shapefile layer by nprigour · Pull Request #261 · locationtech/udig-platform

Conversation

@nprigour

fix for problem described in issue #260.

It seems that corresponding feature iterator was never closed for the copied feature collection and the maintained read locks caused problem when trying a write lock was attempted during commit time.

Signed-off-by: Nikolaos Pringouris nprigour@gmail.com

same shapefile layer

Signed-off-by: Nikolaos Pringouris <nprigour@gmail.com>

@nprigour

@fgdrf

Thanks for providing this patch! Going to test copy & paste within the same layer today ..

@fgdrf fgdrf added this to the uDig-2.0.0 milestone

Jan 9, 2018

fgdrf

queryAttributes.putAll(FeatureUtils.createAttributeMapping(sourceSchema, targetSchema));
Set<String> properties = new HashSet(queryAttributes.values());
return new DefaultQuery(sourceSchema.getName().getLocalPart(), filter, properties
return new Query(sourceSchema.getName().getLocalPart(), filter, properties

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It the switch from DefaultQuery to Query related to the bugfix or just a cleanup here?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just cleanup since DefaultQuery has been marked as deprecated and synonymous to plain Query class

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested context menu in map panel with right mouse -> copy (of selected feature) and pased it on map ✔️
tested also to copy more than one feature ✔️
copy in map-panel and paste onto layer works as expected ✔️

Thanks again for fixing this issue!

2 participants

@nprigour @fgdrf