TCP Appender Refactor by nomiddlename · Pull Request #660 · log4js-node/log4js-node

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@nomiddlename

Copy link

Collaborator

This was originally a rewrite of the tcp/multiprocess appender - to fix #518 - but expanded to include a rewrite of the way the configuration works. As a side effect, this should help with webpack builds as the core appenders are no longer dynamically required.

  • I've removed support for node v4
  • all the cluster code is now in its own module
  • LoggingEvent is responsible for serialising and deserialising itself
  • categories, appenders, levels are now responsible for configuring themselves and validating their own config, with the configuration module responsible just for notifying listeners of a config change and providing some validation helpers

Gareth Jones added 19 commits

October 12, 2017 08:31

@codecov

Copy link

codecov bot commented

Feb 8, 2018

edited

Loading

Codecov Report

Merging #660 into version-3.x will increase coverage by 0.28%.
The diff coverage is 98.49%.

Impacted file tree graph

@@               Coverage Diff               @@
##           version-3.x     #660      +/-   ##
===============================================
+ Coverage        96.14%   96.43%   +0.28%     
===============================================
  Files               29       35       +6     
  Lines             1142     1261     +119     
===============================================
+ Hits              1098     1216     +118     
- Misses              44       45       +1
Impacted Files Coverage Δ
lib/connect-logger.js 100% <100%> (ø) ⬆️
lib/appenders/tcp-server.js 100% <100%> (ø)
lib/logger.js 100% <100%> (+2.17%) ⬆️
lib/log4js.js 97.95% <100%> (+0.45%) ⬆️
lib/LoggingEvent.js 100% <100%> (ø)
lib/clustering.js 100% <100%> (ø)
lib/appenders/recording.js 100% <100%> (ø) ⬆️
lib/configuration.js 100% <100%> (+2.38%) ⬆️
lib/categories.js 100% <100%> (ø)
lib/appenders/categoryFilter.js 100% <100%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05ce809...83aca5b. Read the comment docs.

@nomiddlename nomiddlename added this to the 3.0.0 milestone

Feb 11, 2018

@nomiddlename nomiddlename merged commit 387d8ba into version-3.x

Feb 11, 2018

@nomiddlename nomiddlename deleted the tcp-refactor branch

February 11, 2018 20:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

1 participant

@nomiddlename