TCP Appender Refactor by nomiddlename · Pull Request #660 · log4js-node/log4js-node
Navigation Menu
{{ message }}
log4js-node / log4js-node Public
- Notifications You must be signed in to change notification settings
- Fork 761
Merged
Conversation
Copy link
Collaborator
nomiddlename
commented
Feb 8, 2018
nomiddlename
commented
This was originally a rewrite of the tcp/multiprocess appender - to fix #518 - but expanded to include a rewrite of the way the configuration works. As a side effect, this should help with webpack builds as the core appenders are no longer dynamically required.
- I've removed support for node v4
- all the cluster code is now in its own module
- LoggingEvent is responsible for serialising and deserialising itself
- categories, appenders, levels are now responsible for configuring themselves and validating their own config, with the configuration module responsible just for notifying listeners of a config change and providing some validation helpers
Gareth Jones added 19 commits
October 12, 2017 08:31Copy link
Codecov Report
Merging #660 into version-3.x will increase coverage by
0.28%.
The diff coverage is98.49%.
@@ Coverage Diff @@ ## version-3.x #660 +/- ## =============================================== + Coverage 96.14% 96.43% +0.28% =============================================== Files 29 35 +6 Lines 1142 1261 +119 =============================================== + Hits 1098 1216 +118 - Misses 44 45 +1
| Impacted Files | Coverage Δ | |
|---|---|---|
| lib/connect-logger.js | 100% <100%> (ø) |
⬆️ |
| lib/appenders/tcp-server.js | 100% <100%> (ø) |
|
| lib/logger.js | 100% <100%> (+2.17%) |
⬆️ |
| lib/log4js.js | 97.95% <100%> (+0.45%) |
⬆️ |
| lib/LoggingEvent.js | 100% <100%> (ø) |
|
| lib/clustering.js | 100% <100%> (ø) |
|
| lib/appenders/recording.js | 100% <100%> (ø) |
⬆️ |
| lib/configuration.js | 100% <100%> (+2.38%) |
⬆️ |
| lib/categories.js | 100% <100%> (ø) |
|
| lib/appenders/categoryFilter.js | 100% <100%> (ø) |
⬆️ |
| ... and 9 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 05ce809...83aca5b. Read the comment docs.
Gareth Jones added 2 commits
February 9, 2018 08:22
nomiddlename
added this to the
3.0.0 milestone
nomiddlename
merged commit
387d8ba
into
version-3.x
nomiddlename
deleted the
tcp-refactor
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment