Remove ISF unit detection by bjorkert · Pull Request #494 · loopandlearn/LoopFollow

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@bjorkert

Copy link

Contributor

@bjorkert bjorkert commented

Jan 2, 2026

This auto detection of ISF is not needed for Trio dev since the unit is always milligramsPerDeciliter.

Copy link

Collaborator

@marionbarker marionbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from code review and test.

Test

  • build this branch and view a Trio URL
  • configure the Trio source so that ISF shows an enacted value
  • modify the therapy settings on Trio phone to use ISF = 9 mg/dL/U
  • confirm the ISF in the Information display shows the correct values of 9 mg/dL/U

@bjorkert bjorkert merged commit 21127a2 into dev

Jan 2, 2026

@bjorkert bjorkert deleted the remove-isf-detection branch

January 2, 2026 17:37

codebymini pushed a commit that referenced this pull request

Jan 31, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marionbarker marionbarker marionbarker approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bjorkert @marionbarker