-[MMCoreTextView initWithFrame:] doesn't initialize fontDescent by jjgod · Pull Request #927 · macvim-dev/macvim
Navigation Menu
{{ message }}
macvim-dev / macvim Public
- Notifications You must be signed in to change notification settings
- Fork 689
Merged
ychin merged 2 commits intomacvim-dev:masterfrom
Jul 29, 2019Merged
-[MMCoreTextView initWithFrame:] doesn't initialize fontDescent#927
ychin merged 2 commits intomacvim-dev:masterfrom
-[MMCoreTextView initWithFrame:] doesn't initialize fontDescent#927
ychin merged 2 commits intomacvim-dev:masterfrom
Conversation
Copy link Copy Markdown
Contributor
jjgod
commented
Jul 28, 2019
jjgod
commented
Fixes #883. Makes sure fontDescent is properly initialized by -[MMCoreTextView initWithFrame:].
Copy link Copy Markdown
Contributor
eirnym
commented
Jul 28, 2019
eirnym commented
Jul 28, 2019LGTM
Copy link Copy Markdown
Contributor Author
jjgod
commented
Jul 29, 2019
jjgod commented
Jul 29, 2019PR updated according to comment.
ychin
merged commit
72e6bbf
into
macvim-dev:master
Copy link Copy Markdown
Member
ychin
commented
Jul 29, 2019
ychin commented
Jul 29, 2019Alright looks good. Thanks for the fix.
ychin added a commit to ychin/macvim that referenced this pull request
Oct 16, 2019Recent fix to font initialization (macvim-dev#927) seems to have caused issues with other fonts. Keep the fix but revert to the old way of font initialization by manually creating a new one with point size to not use the other aspects of the font to keep the behavior consistent with previous behavior Fix macvim-dev#928
ychin
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants