Map rendering performance improvements by Sublimis · Pull Request #1599 · mapsforge/mapsforge

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@Sublimis

Copy link

Contributor

@Sublimis Sublimis commented

Dec 27, 2024

edited

Loading

  • Narrowed synchronizations in RenderTheme (Slow rendering with multi threading #1598 )
  • Synchronized RenderInstruction-s
  • Synchronization in Rule
  • StandardRenderer: Extract RenderCallback interface to a field
  • MapWorkerPool: Improved DEBUG_TIMING feature
devemux86 reacted with thumbs up emoji
private final AtomicInteger concurrentJobs = new AtomicInteger();
private final AtomicLong totalExecutions = new AtomicLong();
private final AtomicLong totalTime = new AtomicLong();
public static boolean DEBUG_TIMING = true;
Copy link

Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sublimis This should be false.

@Sublimis

Copy link

Contributor Author

@devemux86 AFAIC this code is ready for master if you agree

@devemux86 devemux86 added this to the 0.23.0 milestone

Dec 30, 2024

@devemux86 devemux86 merged commit bfbbbbc into mapsforge:master

Dec 30, 2024

@devemux86

Copy link

Collaborator

@Sublimis Thanks!

Sublimis reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devemux86 devemux86 devemux86 left review comments

Assignees

No one assigned

Projects

None yet

Milestone

0.23.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Sublimis @devemux86