Stabilise top level imports by filiphr · Pull Request #2984 · mapstruct/mapstruct

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@filiphr

Copy link

Member

@filiphr filiphr commented

Aug 24, 2022

edited

Loading

Some more stabilisation because it seems like the combination of

Are not compatible with each other, and it lead to some test failures on main

Fixes #2990

Copy link

Contributor

@Zegveld Zegveld left a comment

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks better than #2991 closing #2991 as duplicates.
Marked #2990 as to be closed upon merge.

@Zegveld Zegveld linked an issue

Aug 26, 2022

that may be closed by this pull request

@filiphr filiphr merged commit 4fa6622 into mapstruct:main

Aug 26, 2022

@filiphr filiphr deleted the top-level-imports branch

August 26, 2022 17:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zegveld Zegveld Zegveld approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Main branch broken due to handling user-defined imports

2 participants

@filiphr @Zegveld