Home Original page

Avoid unnecessary unboxing of Boolean by prasanth08 · Pull Request #3003 · mapstruct/mapstruct

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@prasanth08

Copy link

Contributor

Changed Boolean.valueOf() to Boolean.parseBoolean() - Boolean.valueOf() returns Boolean while the attributes in Options Class is boolean, Boolean.parseBoolean() returns boolean.
Changed Collections.sort() to List.sort() - Collections.sort() internally calls the List.sort().
Fix Java - doc

Copy link

Member

@filiphr filiphr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes are OK @prasanth08, only one small comment about one of the Javadocs.

Apart from that, can you please rebase this on top of main. I see that there are some conflicts

@prasanth08 prasanth08 requested a review from filiphr

September 9, 2022 15:36

@filiphr filiphr merged commit d593afe into mapstruct:main

Sep 12, 2022

@filiphr

Copy link

Member

filiphr commented

Sep 12, 2022

Thanks @prasanth08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@filiphr filiphr Awaiting requested review from filiphr

Assignees

No one assigned

Projects

None yet

Milestone

1.6.0.Beta1

Development

Successfully merging this pull request may close these issues.

2 participants

@prasanth08 @filiphr