#3172 Adding mapping between Locale and String by Blackbaud-JasonBodnar · Pull Request #3173 · mapstruct/mapstruct
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 1k
Merged
filiphr merged 2 commits intomapstruct:mainfrom
May 8, 2023Merged
#3172 Adding mapping between Locale and String#3173
filiphr merged 2 commits intomapstruct:mainfrom
#3172 Adding mapping between Locale and String#3173
filiphr merged 2 commits intomapstruct:mainfrom
Conversation
filiphr requested changes Apr 15, 2023
Copy link
Member
filiphr
left a comment
filiphr
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Blackbaud-JasonBodnar. This looks good to me. Only some small changes in the testing package and we are good to merge it.
processor/src/test/java/org/mapstruct/ap/test/conversion/locale/uuid/LocaleConversionTest.java
Outdated
Show resolved
Hide resolved
processor/src/test/java/org/mapstruct/ap/test/conversion/locale/uuid/LocaleConversionTest.java Outdated Show resolved Hide resolved
processor/src/test/java/org/mapstruct/ap/test/conversion/locale/uuid/LocaleConversionTest.java
Outdated
Show resolved
Hide resolved
processor/src/test/java/org/mapstruct/ap/test/conversion/locale/uuid/LocaleConversionTest.java Outdated Show resolved Hide resolved
filiphr
merged commit
d0e4c48
into
mapstruct:main
Copy link
Member
filiphr
commented
May 8, 2023
filiphr commented
May 8, 2023Thanks @Blackbaud-JasonBodnar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants