Feat: add menu for tabs by kenyx89 · Pull Request #1434 · marktext/marktext
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 4.1k
Merged
fxha merged 3 commits intomarktext:developfrom
fxha merged 3 commits intomarktext:developfrom
Conversation
Copy link Copy Markdown
Contributor
kenyx89
commented
Oct 2, 2019
kenyx89
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| Fixed tickets | #1369 |
| License | MIT |
Description
Added menu for tabs.
--
Please, don't submit /dist files with your PR!
kenyx89
closed this
kenyx89
reopened this
kenyx89
closed this
kenyx89
reopened this
fxha reviewed Oct 2, 2019
src/renderer/components/editorWithTabs/tabs.vue
Show resolved
Hide resolved
src/renderer/components/editorWithTabs/tabs.vue Show resolved Hide resolved
src/renderer/contextMenu/tabs/index.js
Outdated
Show resolved
Hide resolved
src/renderer/contextMenu/tabs/index.js Outdated Show resolved Hide resolved
fxha
requested a review
from Jocs
Jocs reviewed Oct 4, 2019
src/renderer/components/editorWithTabs/tabs.vue
Show resolved
Hide resolved
src/renderer/components/editorWithTabs/tabs.vue Show resolved Hide resolved
src/renderer/store/editor.js
Show resolved
Hide resolved
src/renderer/store/editor.js Show resolved Hide resolved
src/renderer/store/editor.js
Show resolved
Hide resolved
src/renderer/store/editor.js Show resolved Hide resolved
src/renderer/store/editor.js
Show resolved
Hide resolved
src/renderer/store/editor.js Show resolved Hide resolved
Copy link Copy Markdown
Member
Jocs
requested a review
from fxha
Jocs approved these changes Oct 10, 2019
Copy link Copy Markdown
Contributor Author
kenyx89
commented
Oct 10, 2019
kenyx89 commented
Oct 10, 2019@Jocs where will the New tab menu item be positioned?
Copy link Copy Markdown
Member
Jocs
commented
Oct 10, 2019
Jocs commented
Oct 10, 2019where will the New tab menu item be positioned?
I found it's not necessary now, because I found there is already a + on the right of all tabs. thanks.
Jocs reviewed Oct 10, 2019
src/renderer/components/editorWithTabs/tabs.vue
Show resolved
Hide resolved
src/renderer/components/editorWithTabs/tabs.vue Show resolved Hide resolved
Jocs
self-requested a review
Jocs approved these changes Oct 11, 2019
fxha approved these changes Oct 12, 2019
fxha
merged commit
342e9c4
into
marktext:develop
Copy link Copy Markdown
Contributor
fxha
commented
Oct 12, 2019
fxha commented
Oct 12, 2019Thanks @kenyx89
mlantas
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants