Home Original page

Fix mermaid diagram is not visiable when export html by Jocs · Pull Request #1732 · marktext/marktext

Conversation

@Jocs

Q A
Bug fix? yes
Fixed tickets #1670
License MIT

Description

[Description of the bug or feature]

--

Please, don't submit /dist files with your PR!

This change is Reviewable

fxha

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will show the document twice if you export a document. Please try this document with your change and you will notice that the exported HTML (.ag-render-container container) is visible while exporting. That's was the reason to hide the container.

@Jocs

That's was the reason to hide the container.

Hide this container will cause render mermaid\flowchart incorrectly. So we need to put it out of viewport(off screen).

@Jocs Jocs deleted the fix-export-mermaid branch

November 22, 2019 11:01

@fxha

@Jocs The content is visible again during export on latest develop/v0.16.0-rc2. E.g. export a document with multiple paragraphs and some math formulas.

@Jocs

Maybe we can only use z-index to make the rendered printed page appear below the editor.

2 participants

@Jocs @fxha