numpy 2.0 compatibility np.unicode_ by MatthewFlamm · Pull Request #99 · matplotlib/cmocean
Navigation Menu
{{ message }}
matplotlib / cmocean Public
- Notifications You must be signed in to change notification settings
- Fork 51
Merged
kthyng merged 1 commit intomatplotlib:mainfrom
Jan 22, 2024Merged
numpy 2.0 compatibility np.unicode_#99
kthyng merged 1 commit intomatplotlib:mainfrom
numpy 2.0 compatibility np.unicode_#99
kthyng merged 1 commit intomatplotlib:mainfrom
Conversation
Copy link Copy Markdown
Contributor
MatthewFlamm
commented
Jan 11, 2024
MatthewFlamm
commented
I also assume that the check for python 2.0 is no longer needed since setup.py requires python >= 3.8.
See https://numpy.org/devdocs/numpy_2_0_migration_guide.html#main-namespace
Closes #98
kthyng
merged commit
6b086e0
into
matplotlib:main
Copy link Copy Markdown
Contributor
kthyng
commented
Jan 22, 2024
kthyng commented
Jan 22, 2024@MatthewFlamm Thank you!!
Copy link Copy Markdown
Contributor
kthyng
commented
Jan 23, 2024
kthyng commented
Jan 23, 2024This change is now available in the newest version of cmocean on PyPI (v3.1.3) and should shortly be available on conda-forge too. Thanks again.
kthyng
mentioned this pull request
Closed
Copy link Copy Markdown
Contributor Author
MatthewFlamm
commented
Jan 24, 2024
MatthewFlamm commented
Jan 24, 2024Thanks for quickly releasing!
Copy link Copy Markdown
Contributor
Can I just state again how great this was for you to do? I just hit this myself in my own older version of cmocean and realized you had already fixed it as I was going in to do it myself and couldn't get another version of my code to hit the error because I already had your fix in it. Thanks again!
MatthewFlamm
deleted the
patch-1
branch
adamjstewart
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment