numpy 2.0 compatibility np.unicode_ by MatthewFlamm · Pull Request #99 · matplotlib/cmocean

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@MatthewFlamm

Copy link Copy Markdown

Contributor

I also assume that the check for python 2.0 is no longer needed since setup.py requires python >= 3.8.

See https://numpy.org/devdocs/numpy_2_0_migration_guide.html#main-namespace

Closes #98

@kthyng kthyng merged commit 6b086e0 into matplotlib:main

Jan 22, 2024

@kthyng

Copy link Copy Markdown

Contributor

kthyng commented

Jan 22, 2024

@MatthewFlamm Thank you!!

@kthyng

Copy link Copy Markdown

Contributor

kthyng commented

Jan 23, 2024

This change is now available in the newest version of cmocean on PyPI (v3.1.3) and should shortly be available on conda-forge too. Thanks again.

MatthewFlamm reacted with hooray emoji

@kthyng kthyng mentioned this pull request

Jan 23, 2024

@MatthewFlamm

Copy link Copy Markdown

Contributor Author

Thanks for quickly releasing!

@kthyng

Copy link Copy Markdown

Contributor

kthyng commented

Jul 5, 2024

edited

Loading

Can I just state again how great this was for you to do? I just hit this myself in my own older version of cmocean and realized you had already fixed it as I was going in to do it myself and couldn't get another version of my code to hit the error because I already had your fix in it. Thanks again!

MatthewFlamm and adamjstewart reacted with heart emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

numpy v2.0 compatibility

2 participants

@MatthewFlamm @kthyng