addplot `type='scatter'` support `edgecolors` and `linewidths` by fxhuhn · Pull Request #405

addplot `type='scatter'` support `edgecolors` and `linewidths` by fxhuhn · Pull Request #405 · matplotlib/mplfinance

		linewidths = apdict['linewidths']

		if isinstance(mark,(list,tuple,np.ndarray)):
		_mscatter(xdates,ydata,ax=ax,m=mark,s=size,color=color,alpha=alpha)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markus- Do you see any reason not to also add edgecolors=edgecolors, linewidths=linewidths to the call to _mscatter(). If you look at the code for mscatter() it will simply pass those kwargs down to scatter.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fxhuhn
Markus, Hi. I'm finally getting around to processing the backlog of Pull Requests. This looks fine. Just thinking that maybe we should add edgecolors=edgecolors, linewidths=linewidths to the call to _mscatter() as well. Any thoughts about that?
Thanks. --Daniel

DanielGoldfarb changed the title ~~adding edgecolors and linewidths~~ make_addplot(...type='scatter'...) support edgecolors and linewidths` kwargs

Dec 14, 2021

DanielGoldfarb changed the title ~~make_addplot(...type='scatter'...) support edgecolors and linewidths` kwargs~~ addplot type='scatter' support edgecolors and linewidths

Dec 14, 2021