Removed `if (plottype not in _valid_types_all) ... ` and also `num_panels = config['num_panels']` by anbarief · Pull Request #507 · matplotlib/mplfinance
added 2 commits
March 4, 2022 22:47
This is unnecessary because the kwarg validator already check whether `kwarg['type']` is in `_valid_types_all`. So if the value passed the validator then it must be in `_valid_types_all`. So we don't need to check again in function `_get_valid_plot_types` (unless...this function is used also by function other than `plotting.plot`)
anbarief
changed the title
Removed
Removed if (plottype not in _valid_types_all) ... if (plottype not in _valid_types_all) ... and also num_panels = config['num_panels']
Previously the comments say the max number of panels is 10. So I fixed it to be consistent with the current version, max. panels equal 32.
to show only specific figure created in plotting.py instead of using plt.show we use fig.show. matplotlib#510
This was referenced
Apr 26, 2022This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters