feat: simplify types used to register shapes by tbouffard · Pull Request #768 · maxGraph/maxGraph
Previously, there were TSC errors when registering some builtin or custom shape because their constructor didn't match the signature of the `Shape` constructor. The type of various `CellRenderer` properties and methods has been updated to fix this, so it is no longer necessary to add some 'ts-ignore' to silently ignore these false errors. In addition: - Various improvements in the JSDoc of `CellRenderer` - `CellRenderer.getShape` allows `undefined` parameter - Move `ActorShape` to the directory storing vertex shapes for consistency
tbouffard
marked this pull request as ready for review
tbouffard
changed the title
fix: simplify types used to register shapes
feat: simplify types used to register shapes
tbouffard
deleted the
fix/improve_type_to_registerShape
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters