Add traffic management module to the python libraries by h3lix1 · Pull Request #890 · meshtastic/python
Adding traffic_management to be part of the configuration options when using --set and --get.
This relates to meshtastic/protobufs#849 and can't be pushed until the protobufs are complete.
Placing this in draft for now.
h3lix1
marked this pull request as draft
This all seems reasonable to me; assuming the protobuf and firmware changes also get merged, would you mind pinging me to get back to this whenever it's ready to go out of draft? I'm m_ia_n on discord, which is more likely to catch my attention these days.
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.60%. Comparing base (d0ccb1a) to head (6511d06).
⚠️ Report is 17 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@ ## master #890 +/- ## ========================================== + Coverage 59.82% 60.60% +0.77% ========================================== Files 24 24 Lines 4329 4336 +7 ========================================== + Hits 2590 2628 +38 + Misses 1739 1708 -31
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 60.60% <100.00%> (+0.77%) |
⬆️ |
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
h3lix1
marked this pull request as ready for review
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.
✅ thebentern
✅ h3lix1
❌ github-actions
github-actions seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
@ianmcorvidae should be good to go.. firmware changes are still in progress though.. I'm not sure if this goes ahead of those or not.
Looks good. We really only need the protobufs side of things to put them into this, so I'll get it merged as long as CI doesn't yell about anything
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters