adds more realistic POST response for accounts, with id by jessbowers · Pull Request #943 · mgonto/restangular

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

bostrom merged 1 commit intomgonto:masterfrom

jessbowers:tests-adds-post-id

Nov 20, 2016

Merged

adds more realistic POST response for accounts, with id#943

bostrom merged 1 commit intomgonto:masterfrom

jessbowers:tests-adds-post-id

Conversation

@jessbowers

Copy link

Contributor

POST'ing an account now returns a new account object with the "id" filled in, rather than the client sending it in the POST.

@grabbou

Copy link

Contributor

grabbou commented

Feb 21, 2015

Nice one :) Thanks.

@pedromarce pedromarce added this to the 1.5.3 milestone

Feb 15, 2016

@daviesgeek

Copy link

Collaborator

This looks good @jessbowers . Will probably merge in shortly

@jessbowers

Copy link

Contributor Author

@daviesgeek want me to rebase to bring it up to date?

@jessbowers

Copy link

Contributor Author

rebased

@daviesgeek

Copy link

Collaborator

Sure, thanks. I'll review it and merge when i have some time to read it more thoroughly

@bostrom bostrom merged commit 11fb475 into mgonto:master

Nov 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

1.5.3

Development

Successfully merging this pull request may close these issues.

5 participants

@jessbowers @grabbou @daviesgeek @bostrom @pedromarce