Drop `inline`/`_INLINE_VAR` from templated `constexpr` variables in product and test codes by frederick-vs-ja · Pull Request #4546 · microsoft/STL
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 1.6k
Merged
StephanTLavavej merged 3 commits intomicrosoft:mainfrom
Apr 9, 2024Merged
Conversation
frederick-vs-ja
requested a review
from a team
as a code owner
frederick-vs-ja
force-pushed
the
cwg-2387
branch
from
e18ee96 to
d7e4c4c
Compare
StephanTLavavej
self-assigned this
stl/inc/compare Outdated
StephanTLavavej approved these changes Apr 2, 2024
Copy link Copy Markdown
Member
StephanTLavavej
commented
Apr 2, 2024
StephanTLavavej commented
Apr 2, 2024Thanks for the extremely careful work! I audited all changes for correctness (all were templated), found only one missed occurrence, and then audited all remaining cases of _INLINE_VAR.*constexpr and inline.*constexpr to verify that they were all plain or explicit specializations.
StephanTLavavej
removed their assignment
StephanTLavavej
mentioned this pull request
Merged
StephanTLavavej approved these changes Apr 8, 2024
Copy link Copy Markdown
Member
StephanTLavavej
commented
Apr 8, 2024
StephanTLavavej commented
Apr 8, 2024I've pushed a commit to pre-emptively avoid a merge conflict; #4554 will be removing _INLINE_VAR from _Vector_alg_in_find_is_safe.
StephanTLavavej
self-assigned this
Copy link Copy Markdown
Member
StephanTLavavej
commented
Apr 8, 2024
StephanTLavavej commented
Apr 8, 2024I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.
StephanTLavavej
merged commit
daeb0a6
into
microsoft:main
Copy link Copy Markdown
Member
StephanTLavavej
commented
Apr 9, 2024
StephanTLavavej commented
Apr 9, 2024Thanks for auditing all of these now-unnecessary keywords! 🪄 🔍 🎉
frederick-vs-ja
deleted the
cwg-2387
branch
StephanTLavavej
mentioned this pull request
StephanTLavavej
removed this from STL Code Reviews
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment