Remove deprecated internal method · Pull Request #24540 · microsoft/TypeScript
Navigation Menu
{{ message }}
microsoft / TypeScript Public
- Notifications You must be signed in to change notification settings
- Fork 13.3k
Merged
Conversation
Copy link
ghost
commented
May 31, 2018
ghost
commented
The only history I can find on this is af5148d -- since this method is internal there should be no problem removing it?
ghost
requested a review
from mhegazy
Copy link
Contributor
mhegazy
commented
May 31, 2018
mhegazy commented
May 31, 2018@Andy-MS can you add a note about it in the API breaking changes section.
mhegazy approved these changes May 31, 2018
Copy link
Author
Don't think it's an API breaking change since this wasn't in the public API?
Copy link
Contributor
mhegazy
commented
May 31, 2018
mhegazy commented
May 31, 2018I remember monaco used to take a dependency on it. but they do not any longer. even though it is not part of the public API ppl still use it. we just need to add a note to use getProgram().getSourceFile() instead.
Copy link
Author
ghost
commented
Jun 1, 2018
ghost commented
Jun 1, 2018Updated API breaking changes.
ghost
merged commit
e654442
into
master
ghost
deleted the
deprecated_getsourcefile
branch
microsoft
locked and limited conversation to collaborators
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
1 participant