Refactor node factory API, use node factory in parser by rbuckton · Pull Request #35282 · microsoft/TypeScript

@rbuckton

weswigham

@rbuckton

@rbuckton

@rbuckton

@rbuckton

This was referenced

May 7, 2020

@rbuckton

@rbuckton rbuckton marked this pull request as ready for review

May 8, 2020 02:13

@rbuckton

# Conflicts:
#	src/compiler/factoryPublic.ts
#	src/services/codefixes/convertToAsyncFunction.ts
#	src/services/codefixes/helpers.ts
#	src/services/codefixes/inferFromUsage.ts
#	src/services/signatureHelp.ts
#	tests/baselines/reference/api/tsserverlibrary.d.ts
#	tests/baselines/reference/api/typescript.d.ts

@rbuckton

# Conflicts:
#	src/compiler/binder.ts
#	src/compiler/checker.ts
#	src/compiler/factory.ts
#	src/compiler/transformers/declarations.ts
#	src/compiler/transformers/es2015.ts
#	src/compiler/transformers/module/module.ts
#	src/compiler/transformers/module/system.ts
#	src/compiler/transformers/taggedTemplate.ts
#	src/compiler/transformers/ts.ts
#	src/compiler/utilities.ts
#	src/compiler/visitor.ts
#	src/harness/vfsUtil.ts
#	src/services/codefixes/addMissingAsync.ts
#	src/services/codefixes/convertToMappedObjectType.ts
#	src/services/codefixes/helpers.ts
#	src/services/completions.ts
#	src/services/refactors/generateGetAccessorAndSetAccessor.ts

@rbuckton

RyanCavanaugh

RyanCavanaugh

@rbuckton

edsrzf pushed a commit to edsrzf/ts-migrate that referenced this pull request

Oct 24, 2020
Most ts.create* and ts.update* functions are deprecated as of TypeScript 4.0. The
current plan is to emit noiser and noisier warnings with each version
until the deprecated functions are removed in 4.3.

See this pull request for more details:
microsoft/TypeScript#35282

Some method signatures and names have changed slightly.

The easy way to update is to use the global ts.factory object.
TypeScript transformations also have access to a NodeFactory in their
transformation contexts.

Note that we still use the deprecate getMutableClone function because
its replacement is not included in the TypeScript declarations. See
microsoft/TypeScript#40507

@orta orta mentioned this pull request

Oct 30, 2020

5 tasks

@Lxxyx Lxxyx mentioned this pull request

Dec 29, 2020

jasonreyes9 added a commit to jasonreyes9/ts-migrate that referenced this pull request

Oct 31, 2023
Most ts.create* and ts.update* functions are deprecated as of TypeScript 4.0. The
current plan is to emit noiser and noisier warnings with each version
until the deprecated functions are removed in 4.3.

See this pull request for more details:
microsoft/TypeScript#35282

Some method signatures and names have changed slightly.

The easy way to update is to use the global ts.factory object.
TypeScript transformations also have access to a NodeFactory in their
transformation contexts.

Note that we still use the deprecate getMutableClone function because
its replacement is not included in the TypeScript declarations. See
microsoft/TypeScript#40507

threema-danilo added a commit to threema-ch/threema-desktop that referenced this pull request

Dec 18, 2024
Most `ts.create*` and `ts.update*` functions are deprecated as of
TypeScript 4.0.

See this pull request for more details:
microsoft/TypeScript#35282

Additionally, some API calls (especially `createImportClause`) needed to
be updated because apparently the API changed.

@microsoft microsoft locked as resolved and limited conversation to collaborators

Oct 21, 2025