Always error on property override accessor by sandersn · Pull Request #37894 · microsoft/TypeScript

added 7 commits

April 9, 2020 08:27
Previously this was only an error when useDefineForClassFields: true,
but now it's an error for all code. This is a rare mistake to make, and
usually only occurs in code written before `readonly` was available.

Codefix to come in subsequent commits.
1. Add add-all test
2. Add codefix that delegates to get-set accessor refactor.

Needs massive amounts of cleanup and deduplication.
1. Fix lint.
2. Make code easier to read.
3. Turns some asserts into bails instead.

andrewbranch

@sandersn

@sandersn

1. Follow aliases with getSupers.
2. Make fix in file with superclass, not with the error.

andrewbranch

@sandersn sandersn deleted the always-error-on-property-override-accessor branch

May 26, 2020 17:37

jks-liu added a commit to jks-liu/WPL-s that referenced this pull request

Sep 9, 2021

@microsoft microsoft locked as resolved and limited conversation to collaborators

Oct 21, 2025