fix(41736): tsserver should not crash if external file does not exist by kyliau · Pull Request #41737 · microsoft/TypeScript

DanielRosenwasser

sheetalkamat

@kyliau

If a file does not exist, `projectService.getOrCreateScriptInfoNotOpenedByClient()`
will return `undefined`, but tsserver does not handle this case.

Fix microsoft#41736

sheetalkamat

@kyliau kyliau deleted the external-files branch

December 1, 2020 00:39

kyliau added a commit to kyliau/angular that referenced this pull request

Dec 2, 2020
…exist

There is a bug in tsserver that causes it to crash when it tries to create
script info for an external template that does not exist.

I've submitted an upstream PR
microsoft/TypeScript#41737 to fix this, but before
the commit lands in the stable release, we'll have to workaround the issue
in language service.

Close angular/vscode-ng-language-service#1001

mhevery pushed a commit to angular/angular that referenced this pull request

Dec 3, 2020
…exist (#39898)

There is a bug in tsserver that causes it to crash when it tries to create
script info for an external template that does not exist.

I've submitted an upstream PR
microsoft/TypeScript#41737 to fix this, but before
the commit lands in the stable release, we'll have to workaround the issue
in language service.

Close angular/vscode-ng-language-service#1001

PR Close #39898

mhevery pushed a commit to angular/angular that referenced this pull request

Dec 3, 2020
…exist (#39898)

There is a bug in tsserver that causes it to crash when it tries to create
script info for an external template that does not exist.

I've submitted an upstream PR
microsoft/TypeScript#41737 to fix this, but before
the commit lands in the stable release, we'll have to workaround the issue
in language service.

Close angular/vscode-ng-language-service#1001

PR Close #39898

@microsoft microsoft locked as resolved and limited conversation to collaborators

Oct 21, 2025