🤖 Pick PR #58895 (Fix global when typescript.js loade...) into release-5.5 by typescript-bot · Pull Request #58896 · microsoft/TypeScript
Navigation Menu
{{ message }}
microsoft / TypeScript Public
- Notifications You must be signed in to change notification settings
- Fork 13.3k
Merged
🤖 Pick PR #58895 (Fix global when typescript.js loade...) into release-5.5#58896
jakebailey merged 1 commit intorelease-5.5from
🤖 Pick PR #58895 (Fix global when typescript.js loade...) into release-5.5#58896
jakebailey merged 1 commit intorelease-5.5from
Conversation
Copy link Copy Markdown
Collaborator
typescript-bot
commented
Jun 17, 2024
typescript-bot
commented
This cherry-pick was triggered by a request on #58895.
Please review the diff and merge if no changes are unexpected.
typescript-bot
requested review from
DanielRosenwasser and
jakebailey
typescript-bot
added
For Uncommitted Bug
labels
Jun 17, 2024
typescript-bot
mentioned this pull request
typescript-bot
force-pushed
the
cherry-pick/58895/release-5.5
branch
from
26cdc45 to
6ff91dd
Compare
RyanCavanaugh approved these changes Jun 17, 2024
Copy link Copy Markdown
Member
jakebailey
commented
Jun 17, 2024
jakebailey commented
Jun 17, 2024@typescript-bot pack this
want to verify esm.sh real quick
Copy link Copy Markdown
Collaborator Author
Starting jobs; this comment will be updated as builds start and complete.
| Command | Status | Results |
|---|---|---|
pack this |
✅ Started |
Copy link Copy Markdown
Member
jakebailey
commented
Jun 17, 2024
jakebailey commented
Jun 17, 2024Oh that task doesn't work on release branches, oof
Copy link Copy Markdown
Member
jakebailey
commented
Jun 17, 2024
jakebailey commented
Jun 17, 2024I checked esm.sh directly; they actually more or less just use the cjs-module-lexer (ported to Go) and then extract out the exports then wrap the module in a fake CJS context, so all good.
jakebailey
merged commit
02132e5
into
release-5.5
jakebailey
deleted the
cherry-pick/58895/release-5.5
branch
sandersn
removed this from PR Backlog
microsoft
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.