Allow declarationMap to be emitted when transpiling declarations and option is enabled by sheetalkamat · Pull Request #59337 · microsoft/TypeScript
Navigation Menu
{{ message }}
microsoft / TypeScript Public
- Notifications You must be signed in to change notification settings
- Fork 13.3k
Merged
Allow declarationMap to be emitted when transpiling declarations and option is enabled#59337
sheetalkamat merged 2 commits intomainfrom
Allow declarationMap to be emitted when transpiling declarations and option is enabled#59337
sheetalkamat merged 2 commits intomainfrom
Conversation
sheetalkamat added 2 commits
July 17, 2024 15:59…option is enabled Fixes #59313
typescript-bot
assigned
sheetalkamat
typescript-bot
added
Author: Team
For Uncommitted Bug
labels
Jul 17, 2024
sheetalkamat
mentioned this pull request
sheetalkamat
requested review from
DanielRosenwasser,
jakebailey and
weswigham
weswigham approved these changes Jul 17, 2024
Copy link Copy Markdown
codecov-commenter
commented
Jul 17, 2024
codecov-commenter commented
Jul 17, 2024Codecov Report
All modified and coverable lines are covered by tests ✅
Please upload report for BASE (
main@e7e8135). Learn more about missing BASE report.
Additional details and impacted files
@@ Coverage Diff @@ ## main #59337 +/- ## ======================================= Coverage ? 94.07% ======================================= Files ? 587 Lines ? 300852 Branches ? 5082 ======================================= Hits ? 283023 Misses ? 12747 Partials ? 5082
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
Copy link Copy Markdown
Member
DanielRosenwasser
commented
Jul 17, 2024
DanielRosenwasser commented
Jul 17, 2024Should this be picked back to 5.5?
Copy link Copy Markdown
Member
jakebailey
commented
Jul 17, 2024
jakebailey commented
Jul 17, 2024Probably?
sheetalkamat
merged commit
afa03f0
into
main
sheetalkamat
deleted the
transpileDeclarations
branch
sheetalkamat
added this to the
TypeScript 5.5.4 milestone
Copy link Copy Markdown
Member Author
sheetalkamat
commented
Jul 18, 2024
sheetalkamat commented
Jul 18, 2024@typescript-bot cherry-pick this to release-5.5
Copy link Copy Markdown
Collaborator
typescript-bot pushed a commit that referenced this pull request
Jul 18, 2024…option is enabled (#59337)
typescript-bot
mentioned this pull request
Copy link Copy Markdown
Collaborator
typescript-bot
commented
Jul 18, 2024
typescript-bot commented
Jul 18, 2024Hey, @sheetalkamat! I've created #59344 for you.
DanielRosenwasser pushed a commit that referenced this pull request
Jul 19, 2024…e-5.5 (#59344) Co-authored-by: Sheetal Nandi <shkamat@microsoft.com>
sandersn
removed this from PR Backlog
microsoft
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
7 participants