[JavaToolInstallerV0] Add .dmg and .pkg support for macOS by ekaterina-tatanova · Pull Request #13203 · microsoft/azure-pipelines-tasks

Conversation

@ekaterina-tatanova

Task name: JavaToolInstallerV0

Description: This PR adds .dmg and .pkg support for macOS.

Refactoring:

  • Changed the logic of function getting a supporting ending of file name
  • Changed the way of checking if the string is undefined
  • Added missing types to variables and functions results
  • Created a task utils module
  • Added JSDoc to functions
  • United two imports from the same module
  • Logic for unpacking the archive was extracted into a separate function

Documentation changes required: (Y)

Added unit tests: (N)

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@ekaterina-tatanova ekaterina-tatanova changed the title Users/ekaterina tatanova/feature1709682 dmg and pkg support for macos [JavaToolInstallerV0] Add .dmg and .pkg support for macOS

Jun 30, 2020

anatolybolshakov

alexander-smolyakov

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at the comments, other changes are LGTM, thanks!

anatolybolshakov

anatolybolshakov

anatolybolshakov

anatolybolshakov

anatolybolshakov

anatolybolshakov

anatolybolshakov

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

leantk

@leantk

We should also make an issue to add canary tests for these new scenarios

egor-bryzgalov

anatolybolshakov

anatolybolshakov

anatolybolshakov

anatolybolshakov

anatolybolshakov

alexander-smolyakov

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please take a look at the comments?
Other changes LGTM.

egor-bryzgalov

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anatolybolshakov

alexander-smolyakov

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!