Home Original page

Bump parse-duration from 1.1.0 to 2.1.3 in /cli by dependabot[bot] · Pull Request #95 · microsoft/code-push-server

@dependabot

@dependabot bot added the dependencies

Pull requests that update a dependency file

label

Feb 12, 2025

lucen-ms

@lucen-ms lucen-ms deleted the dependabot/npm_and_yarn/cli/parse-duration-2.1.3 branch

February 13, 2025 10:44

This was referenced

Feb 13, 2025

lucen-ms pushed a commit that referenced this pull request

Feb 14, 2025 
NPM package
[parse-duration](https://www.npmjs.com/package/parse-duration) version
was bumped from `1.1.0` to `2.1.3` In PR #95 for CodePush CLI. This
caused the build to fail with the following error:

```shell
% npm run build

> code-push-cli@0.0.1 build
> tsc

script/command-parser.ts:1321:21 - error TS2349: This expression is not callable.
  Type 'typeof import("/private/tmp/ms-code-push-server/cli/node_modules/parse-duration/index")' has no call signatures.

1321   return Math.floor(parseDuration(durationString));
                         ~~~~~~~~~~~~~


Found 1 error in script/command-parser.ts:1321
```

As current code-base is not compatible with `parse-duration` versions
`2.0.0+`, restrict `parse-duration` to use version `1.x.y`.

itujo pushed a commit to Idea-Maker/code-push-server that referenced this pull request

Feb 21, 2025

itujo pushed a commit to Idea-Maker/code-push-server that referenced this pull request

Feb 21, 2025 
NPM package
[parse-duration](https://www.npmjs.com/package/parse-duration) version
was bumped from `1.1.0` to `2.1.3` In PR microsoft#95 for CodePush CLI. This
caused the build to fail with the following error:

```shell
% npm run build

> code-push-cli@0.0.1 build
> tsc

script/command-parser.ts:1321:21 - error TS2349: This expression is not callable.
  Type 'typeof import("/private/tmp/ms-code-push-server/cli/node_modules/parse-duration/index")' has no call signatures.

1321   return Math.floor(parseDuration(durationString));
                         ~~~~~~~~~~~~~


Found 1 error in script/command-parser.ts:1321
```

As current code-base is not compatible with `parse-duration` versions
`2.0.0+`, restrict `parse-duration` to use version `1.x.y`.