Work Item / Issue Reference

AB#40420

Summary

This pull request refactors the way temporary buffers are managed for setting connection attributes in the Connection class, improving memory safety and simplifying buffer handling. Instead of using static vectors to store temporary string and binary data, the code now uses member variables to hold these buffers directly within each Connection instance.

Buffer Management Refactor:

• Removed static vectors (wstr_buffers, buffers) for storing temporary wide string and binary buffers, eliminating the need for manual buffer growth management and cleanup. [1] [2] [3]
• Added member variables wstrStringBuffer and strBytesBuffer to the Connection class for managing temporary buffers per connection instance, improving encapsulation and memory safety.
• Updated all relevant buffer usage in setAttribute to use these new member variables, replacing references to static buffers with instance variables. [1] [2] [3]

Code Simplification:

• Removed unnecessary static buffer and related logic, such as buffer size limits and periodic cleanup, resulting in cleaner and more maintainable code. [1] [2] [3]

  254     } else if (py::isinstance<py::bytes>(value) ||
  255                py::isinstance<py::bytearray>(value)) {
  256         try {
  257             std::string binary_data = value.cast<std::string>();
! 258             this->strBytesBuffer.clear();
! 259             this->strBytesBuffer = std::move(binary_data);
! 260             SQLPOINTER ptr = const_cast<char*>(this->strBytesBuffer.c_str());
! 261             SQLINTEGER length = static_cast<SQLINTEGER>(this->strBytesBuffer.size());
  262 
  263             SQLRETURN ret = SQLSetConnectAttr_ptr(_dbcHandle->get(),
  264                                                   attribute, ptr, length);
  265             if (!SQL_SUCCEEDED(ret)) {