FEAT: Add py.typed marker by cnaples79 ยท Pull Request #367 ยท microsoft/mssql-python
Fixes #359
Summary
- add PEP 561 py.typed marker so type checkers see bundled stubs
- include marker in package_data for distribution
Rationale
- fixes missing typing marker reported in Library Missing Stub File Typed #359 to avoid linter warnings after install
Changes
- add mssql_python/py.typed
- ship py.typed via setup.py package_data
Hi @cnaples79
Thank you for raising this PR, appreciate your efforts. We will review the PR and share our comments (if any).
Please allow us a few days' time to get back on this. We will assign it to the appropriate engineer by tomorrow.
Regards,
Sumit
Hi @cnaples79 - Thanks for raising this.. The PR looks good to go!
Requesting you to resolve the conflicts so that we can start CI pipelines and merge this off, please let us know if you have any queries.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conflicts need to be resolved before merge, else lgtm
bewithgaurav
changed the title
Add py.typed marker
FEAT: Add py.typed marker
๐ Code Coverage Report
๐ฅ Diff Coverage100% |
๐ฏ Overall Coverage76% |
๐ Total Lines Covered: |
Diff Coverage
Diff: main...HEAD, staged and unstaged changes
No lines with coverage information in this diff.
๐ Files Needing Attention
๐ Files with overall lowest coverage (click to expand)
mssql_python.pybind.logger_bridge.hpp: 58.8% mssql_python.pybind.logger_bridge.cpp: 59.2% mssql_python.row.py: 66.2% mssql_python.pybind.ddbc_bindings.cpp: 69.3% mssql_python.pybind.ddbc_bindings.h: 69.7% mssql_python.pybind.connection.connection.cpp: 75.3% mssql_python.ddbc_bindings.py: 79.6% mssql_python.pybind.connection.connection_pool.cpp: 79.6% mssql_python.connection.py: 84.1% mssql_python.cursor.py: 84.7%
๐ Quick Links
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters