Python: added num_records parameter to text memory skill by eavanvalkenburg · Pull Request #2236 · microsoft/semantic-kernel

@eavanvalkenburg

@shawncal shawncal added the python

Pull requests for the Python Semantic Kernel

label

Jul 31, 2023

@shawncal shawncal changed the title added num_records parameter to text memory skill Python: added num_records parameter to text memory skill

Jul 31, 2023

shawncal

@eavanvalkenburg

@eavanvalkenburg

TaoChenOSU

@eavanvalkenburg

@eavanvalkenburg

awharrison-28

@awharrison-28

@awharrison-28

alexchaomander

SOE-YoungS pushed a commit to SOE-YoungS/semantic-kernel that referenced this pull request

Nov 1, 2023
)

### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
The `text_memory_skill` in the core skills was setup to only return 1
record, while the underlying memories all have support for multiple, so
I added a parameter to the recall function to use that.

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->
Added parameter, passed that on to the memory call.
### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

---------

Co-authored-by: Shawn Callegari <36091529+shawncal@users.noreply.github.com>
Co-authored-by: Abby Harrison <54643756+awharrison-28@users.noreply.github.com>