Update python-integration-tests.yml by lemillermicrosoft · Pull Request #2555 · microsoft/semantic-kernel
Fix variable expansion in conditional -- hypothesis is that the value is expanded before the step runs, ruining things.
shawncal
deleted the
lemillermicrosoft-patch-1
branch
github-merge-queue bot pushed a commit that referenced this pull request
Aug 24, 2023### Motivation and Context PRs #2533 and #2555 updated the integration tests to trigger off of python changes only, but did not actually have the resulting jobs require the path filtering. This means that the tests never run. ### Description Add path-filter job as a requirement for subsequent jobs. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Co-authored-by: Lee Miller <lemiller@microsoft.com>
SOE-YoungS pushed a commit to SOE-YoungS/semantic-kernel that referenced this pull request
Nov 1, 2023SOE-YoungS pushed a commit to SOE-YoungS/semantic-kernel that referenced this pull request
Nov 1, 2023This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters