Home Original page

Add ability to change screencast keyboard font size by AlexStrNik · Pull Request #88308 · microsoft/vscode

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

lszomoru merged 8 commits intomicrosoft:masterfrom

AlexStrNik:screencast-font-size

May 12, 2020

Merged

Add ability to change screencast keyboard font size#88308

lszomoru merged 8 commits intomicrosoft:masterfrom

AlexStrNik:screencast-font-size

Conversation

@AlexStrNik

Copy link Copy Markdown

Contributor

@AlexStrNik AlexStrNik commented

Jan 8, 2020

•

edited

Loading

Add the ability to change screencast keyboard font size. This PR adds screencastMode.fontSize setting.
Fixes #88097

tommai78101 and JUD210 reacted with thumbs up emoji

@connor4312 connor4312 requested review from bpasero and joaomoreno and removed request for bpasero and joaomoreno

January 8, 2020 23:29

@bpasero bpasero assigned joaomoreno and unassigned bpasero

Jan 9, 2020

@AlexStrNik

Copy link Copy Markdown

Contributor Author

Some examples:

image
image
image

@AlexStrNik

Copy link Copy Markdown

Contributor Author

After some thought, I decided to rework the keyboard's height calculation method. Now it looks much better.

image
Maximum size
image
Minimum size
image
And at last default size

gjsjohnmurray and AlexStrNik reacted with thumbs up emoji

@joaomoreno joaomoreno added this to the Backlog milestone

Jan 14, 2020

@AlexStrNik

Copy link Copy Markdown

Contributor Author

AlexStrNik commented

Jan 15, 2020

•

edited

Loading

@joaomoreno why not release this feature in January 2020? As far as I know, Endgame hasn't started yet. And I hope this feature will be helpful for someone

@AlexStrNik

Copy link Copy Markdown

Contributor Author

@joaomoreno any updates about this PR?

AlexStrNik and JUD210 reacted with confused emoji

@JUD210

Copy link Copy Markdown

JUD210 commented

Mar 16, 2020

I can't believe why it isn't merged yet!
WHY?

@AlexStrNik AlexStrNik mentioned this pull request

May 12, 2020

@lszomoru lszomoru self-requested a review

May 12, 2020 09:04

@lszomoru lszomoru self-assigned this

May 12, 2020

@lszomoru lszomoru modified the milestones: Backlog, May 2020

May 12, 2020
Copy link Copy Markdown

Member

@joaomoreno joaomoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS still references a fontSize: 56px for the .screencast-keyboard element.

@lszomoru

Copy link Copy Markdown

Member

@AlexStrNik, it seems that you would have to move the css changes into actions.css since screencast.css was renamed.

AlexStrNik and others added 3 commits

May 12, 2020 16:40

@AlexStrNik

Copy link Copy Markdown

Contributor Author

@AlexStrNik, it seems that you would have to move the css changes into actions.css since screencast.css was renamed.

Done!

@lszomoru lszomoru merged commit 8456789 into microsoft:master

May 12, 2020

@github-actions github-actions bot locked and limited conversation to collaborators

Jun 29, 2020

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@joaomoreno joaomoreno joaomoreno requested changes

@lszomoru lszomoru lszomoru approved these changes

Projects

None yet

Milestone

May 2020

Development

Successfully merging this pull request may close these issues.

[Screencast Mode] Allow users to customize font sizes for displaying keyboard shortcuts

5 participants

@AlexStrNik @JUD210 @lszomoru @joaomoreno @bpasero