handle windows paths beginning with \\?\ by connorskees · Pull Request #95147

handle windows paths beginning with \\?\ by connorskees · Pull Request #95147 · microsoft/vscode

Merged

Tyriar merged 2 commits intomicrosoft:masterfrom

connorskees:issue-94961

Apr 14, 2020

Merged

handle windows paths beginning with \\?\#95147
Tyriar merged 2 commits intomicrosoft:masterfrom
connorskees:issue-94961

Conversation

Copy link Copy Markdown

Contributor

connorskees commented
Apr 13, 2020

This should resolve #94961. It does so by optionally allowing drives to be prefixed by \\?\.

@Tyriar

Copy link Copy Markdown

msftclas commented
Apr 13, 2020
•

edited

Loading

All CLA requirements met.

connorskees changed the title ~~handle windows paths beginning with \\?"~~ handle windows paths beginning with \\?\

Apr 13, 2020

handle windows paths beginning with \\?\

663789c

connorskees force-pushed the issue-94961 branch from e6cd2b9 to 663789c Compare

April 13, 2020 19:51

Copy link Copy Markdown

Contributor Author

connorskees commented
Apr 14, 2020

I'm having trouble replicating the CI errors locally. yarn run mocha --run src/vs/platform/backup/test/electron-main/backupMainService.test.ts says everything is fine, but in CI it timed out,

1) BackupMainService dedupeFolderWorkspaces should ignore duplicates on Windows and Mac (root workspace):
Error: timeout of 5000ms exceeded. Ensure the done() callback is being called in this test.

Should I just retry it?

connorskees force-pushed the issue-94961 branch from b98b047 to 663789c Compare

April 14, 2020 05:19

chrmarti assigned Tyriar

Apr 14, 2020

Copy link Copy Markdown

Contributor

Tyriar commented
Apr 14, 2020

Seems like a flake, also the ci.yml one can probably be ignored so this looks all good. Thanks for covering the new developments too with terminalValidatedLocalLinkProvider.test.ts 😄