Add transition to backdrop-filter when dragging elements by 5onderling · Pull Request #95217 · microsoft/vscode
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 38.9k
Merged
Add transition to backdrop-filter when dragging elements#95217
sbatten merged 2 commits intomicrosoft:masterfrom
5onderling:patch-1
Add transition to backdrop-filter when dragging elements#95217
sbatten merged 2 commits intomicrosoft:masterfrom
5onderling:patch-1
Conversation
Copy link Copy Markdown
Contributor
5onderling
commented
Apr 14, 2020
5onderling
commented
Add transition to backdrop-filter when dragging elements
- There is no issue, I just think there should be a transition when the editor gets blurred
- You can test my change by dragging an icon from the left and watching for a transition on the editor from normal to blur.
Add transition to backdrop-filter when dragging elements
5onderling
changed the title
Update part.css
Add transition to backdrop-filter when dragging elements
Copy link Copy Markdown
Member
sbatten
commented
Apr 15, 2020
sbatten commented
Apr 15, 2020@eamodio since you were seeing perf issues when we had a transition, do you mind testing this branch on your potato?
Copy link Copy Markdown
Contributor
eamodio
commented
Apr 15, 2020
eamodio commented
Apr 15, 2020Sure can try it out
Copy link Copy Markdown
Contributor
eamodio
commented
Apr 16, 2020
eamodio commented
Apr 16, 2020@sbatten Looks good to me!
sbatten
self-requested a review
sbatten approved these changes Apr 17, 2020
sbatten
added this to the
April 2020 milestone
sbatten
merged commit
2950816
into
microsoft:master
5onderling
deleted the
patch-1
branch
github-actions
bot
locked and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
3 participants