Fixes clicking on problems filter inputbox makes problems panel callapse by jeanp413 · Pull Request #96203 · microsoft/vscode
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 38.8k
Merged
sandy081 merged 2 commits intomicrosoft:masterfrom
Apr 27, 2020Merged
Fixes clicking on problems filter inputbox makes problems panel callapse#96203
sandy081 merged 2 commits intomicrosoft:masterfrom
Fixes clicking on problems filter inputbox makes problems panel callapse#96203
sandy081 merged 2 commits intomicrosoft:masterfrom
Conversation
sbatten
assigned
sandy081 and
sbatten
Copy link Copy Markdown
Member
sandy081
commented
Apr 27, 2020
sandy081 commented
Apr 27, 2020Seems the fix will fix the issue but trying to understand why the click on input box is triggering collapse button?
sandy081
added this to the
April 2020 milestone
Copy link Copy Markdown
Contributor Author
jeanp413
commented
Apr 27, 2020
jeanp413 commented
Apr 27, 2020@sandy081 The event is bubbling up so ⬇️ also gets triggered.
vscode/src/vs/base/browser/ui/splitview/paneview.ts
Lines 218 to 223 in 9f45c20
| this._register(domEvent(this.header, 'click') | |
| (e => { | |
| if (!e.defaultPrevented) { | |
| this.setExpanded(!this.isExpanded()); | |
| } | |
| }, null)); |
Copy link Copy Markdown
Member
sandy081
commented
Apr 27, 2020
sandy081 commented
Apr 27, 2020Ah I see. Thanks for explanation.
sandy081 approved these changes Apr 27, 2020
Copy link Copy Markdown
Member
sandy081
left a comment
sandy081
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sandy081
merged commit
94c469d
into
microsoft:master
jeanp413
deleted the
fix-96009
branch
github-actions
bot
locked and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
3 participants