Fix empty item in explorer after clicking on Collapse Folders action while editing new file/folder by jeanp413 · Pull Request #96853 · microsoft/vscode
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 38.8k
Merged
isidorn merged 1 commit intomicrosoft:masterfrom
May 4, 2020Merged
Conversation
Copy link Copy Markdown
Contributor
This PR fixes #96846
- Call
this.tree.domFocusin thecollapseAllmethod only if we are editing the explorer to cancel it. - Add a
cancelEditing(defaulttrue) parameter to therefreshmethod, the only place we don't want to cancel edit while refreshing is in thesetEditablemethod. With this change the timeout in explorerViewer is not necessary.
Tested this locally on Ubuntu 18.04 on #96846, #96198, #96566
Copy link Copy Markdown
Collaborator
isidorn
commented
May 4, 2020
isidorn commented
May 4, 2020Tried it out and it looks great. Also awesome that you removed the timeout!
Thanks a lot for improving the explorer ☀️
isidorn
merged commit
bddccf8
into
microsoft:master
isidorn
added this to the
May 2020 milestone
jeanp413
deleted the
fix-96846
branch
github-actions
bot
locked and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
2 participants