Add terminal colors to Monokai Dimmed theme by JanisGailis · Pull Request #98323 · microsoft/vscode

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@JanisGailis

Copy link Copy Markdown

Terminal colors are taken from Monokai, with the exception for ANSI
black, which is the editor background color.

This PR fixes #98322

Terminal colors are taken from Monokai, with the exception for ANSI
black, which is the editor background color.

@msftclas

Copy link Copy Markdown

msftclas commented

May 21, 2020

edited

Loading

CLA assistant check
All CLA requirements met.

Copy link Copy Markdown

Contributor

@miguelsolorio miguelsolorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This looks much better, thanks for the PR!

@miguelsolorio miguelsolorio merged commit 3f8a1a4 into microsoft:master

May 26, 2020

@miguelsolorio miguelsolorio added this to the May 2020 milestone

May 26, 2020

@miguelsolorio miguelsolorio added the themes

Color theme issues

label

May 26, 2020

@github-actions github-actions bot locked and limited conversation to collaborators

Jul 10, 2020

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@miguelsolorio miguelsolorio miguelsolorio approved these changes

Reviewers whose approvals may not affect merge requirements

Labels

themes

Color theme issues

Projects

None yet

Milestone

May 2020

Development

Successfully merging this pull request may close these issues.

Add terminal colors to Monokai Dimmed theme

3 participants

@JanisGailis @msftclas @miguelsolorio