Fix debug icon. Use Codicons instead of text by IllusionMH · Pull Request #98716 · microsoft/vscode
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 38.9k
Merged
miguelsolorio merged 1 commit intomicrosoft:masterfrom
May 28, 2020Merged
Fix debug icon. Use Codicons instead of text#98716
miguelsolorio merged 1 commit intomicrosoft:masterfrom
Fix debug icon. Use Codicons instead of text#98716
miguelsolorio merged 1 commit intomicrosoft:masterfrom
Conversation
Copy link Copy Markdown
Contributor
This PR fixes #98704
- Updated character code for
debug-altto match vscode-codicons repo change - Used
Codiconsnamespace instead of string to match other places.
/cc @misolori
UPD. Failed test on Mac looks unrelated
egamma
assigned
miguelsolorio
egamma
mentioned this pull request
Closed
miguelsolorio approved these changes May 28, 2020
Copy link Copy Markdown
Contributor
miguelsolorio
left a comment
miguelsolorio
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this and updating!
miguelsolorio
merged commit
1dc2f7c
into
microsoft:master
miguelsolorio
added this to the
May 2020 milestone
IllusionMH
deleted the
fix-debug-icon-98704
branch
Copy link Copy Markdown
Contributor Author
IllusionMH
commented
May 28, 2020
IllusionMH commented
May 28, 2020@misolori thanks for review!
github-actions
bot
locked and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
2 participants