Prevent opaque highlight color from hiding text by ChrisPapp · Pull Request #98974 · microsoft/vscode

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@ChrisPapp

Copy link Copy Markdown

Contributor

@ChrisPapp ChrisPapp commented

Jun 1, 2020

edited

Loading

This PR fixes #97521

It's a "magic" solution but I understand that this is temporary until the bug in the terminal library is fixed.

@ChrisPapp ChrisPapp force-pushed the highlight_color_97521 branch from e8c3318 to ebd51e1 Compare

June 1, 2020 18:53

@ChrisPapp ChrisPapp force-pushed the highlight_color_97521 branch from ebd51e1 to a124cc6 Compare

June 1, 2020 18:55
Copy link Copy Markdown

Contributor

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made it 50% so the text is a little more visible, thanks!

ChrisPapp reacted with thumbs up emoji

@Tyriar Tyriar added this to the May 2020 milestone

Jun 1, 2020

@Tyriar Tyriar merged commit cc09e1d into microsoft:master

Jun 1, 2020

@github-actions github-actions bot locked and limited conversation to collaborators

Jul 16, 2020

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@Tyriar Tyriar Tyriar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Tyriar Tyriar

Labels

None yet

Projects

None yet

Milestone

May 2020

Development

Successfully merging this pull request may close these issues.

Path gets blacked on hover in terminal if hoverHighlightBackground is opaque

2 participants

@ChrisPapp @Tyriar