Fix the file watcher by bobbrow · Pull Request #1983

Fix the file watcher by bobbrow · Pull Request #1983 · microsoft/vscode-cpptools

Merged

bobbrow merged 1 commit intomasterfrom

bobbrow/filewatcher

May 11, 2018

Merged

Fix the file watcher#1983
bobbrow merged 1 commit intomasterfrom
bobbrow/filewatcher

Conversation

Copy link Copy Markdown

Member

bobbrow commented
May 11, 2018

Something must have changed in VS Code with the file watcher API because we stopped getting file created/deleted events. This change fixes it.

Fix the file watcher

61ec33e

bobbrow commented May 11, 2018

View reviewed changes

Extension/src/LanguageServer/client.ts

		// WARNING: The default limit on Linux is 8k, so for big directories, this can cause file watching to fail.
		this.rootPathFileWatcher = vscode.workspace.createFileSystemWatcher(
		path.join(this.RootPath, "*"),
		"*/",

Copy link Copy Markdown

Member Author

bobbrow
May 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that we don't get file delete notifications for every file in a deleted folder, so we'll need to update the language server to take care of that specially.