Move pytest test IDs file deletion to finally block by itaihay · Pull Request #25540 · microsoft/vscode-python

@itaihay marked this pull request as ready for review

October 22, 2025 13:38

@itaihay

If the vscode-pytest execution is wrapped and re-triggered then
the deletion of the file causes the second run the fail.
Deleting the file on the finally block ensures that the pytest
execution will work even if re-run.

- Move the deletion of the test IDs temp file from before pytest
  execution to a `finally` block.
- This ensures the temp file is always cleaned up, even if pytest
  execution fails or an exception occurs.
- Move `ids_path` initialization outside the try block so it's
  accessible in the finally block for cleanup.

@eleanorjboyd

@eleanorjboyd eleanorjboyd added the debt

Covers everything internal: CI, testing, refactoring of the codebase, etc.

label

Nov 10, 2025

eleanorjboyd

rzhao271