Add command builder with escaped user input by AmelBawa-msft · Pull Request #5982 · microsoft/winget-cli
Navigation Menu
{{ message }}
microsoft / winget-cli Public
- Notifications You must be signed in to change notification settings
- Fork 1.7k
Merged
AmelBawa-msft merged 9 commits intomicrosoft:masterfrom
Jan 23, 2026Merged
Add command builder with escaped user input#5982
AmelBawa-msft merged 9 commits intomicrosoft:masterfrom
Add command builder with escaped user input#5982
AmelBawa-msft merged 9 commits intomicrosoft:masterfrom
Conversation
Copy link
Contributor
- I have signed the Contributor License Agreement.
- I have updated the Release Notes.
- This pull request is related to an issue.
- 🧱 Add a command builder with escaped user input
- ⚠️ Unfortunately, using
StartInfo.ArgumentListis not available in net48, hence manually implementing the escape method. - 🧪 Added unit tests
Microsoft Reviewers: Open in CodeFlow
AmelBawa-msft added 2 commits
January 14, 2026 23:25AmelBawa-msft commented Jan 15, 2026
src/PowerShell/Microsoft.WinGet.Client.Engine/Helpers/WinGetCLICommandBuilder.cs
Show resolved
Hide resolved
src/PowerShell/Microsoft.WinGet.Client.Engine/Helpers/WinGetCLICommandBuilder.cs Show resolved Hide resolved
AmelBawa-msft added 2 commits
January 21, 2026 15:49
AmelBawa-msft
marked this pull request as ready for review
AmelBawa-msft
requested a review
from a team
as a code owner
This comment has been minimized.
This comment has been minimized.
AmelBawa-msft added 2 commits
January 21, 2026 16:04JohnMcPMS reviewed Jan 22, 2026
Copy link
Member
JohnMcPMS
left a comment
JohnMcPMS
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the tests to the pipeline as well so that we get coverage.
src/PowerShell/Microsoft.WinGet.Client.Engine/Helpers/WinGetCLICommandBuilder.cs
Outdated
Show resolved
Hide resolved
src/PowerShell/Microsoft.WinGet.Client.Engine/Helpers/WinGetCLICommandBuilder.cs Outdated Show resolved Hide resolved
src/PowerShell/Microsoft.WinGet.Client.Engine/Helpers/WinGetCLICommandBuilder.cs
Show resolved
Hide resolved
src/PowerShell/Microsoft.WinGet.Client.Engine/Helpers/WinGetCLICommandBuilder.cs Show resolved Hide resolved
src/PowerShell/Microsoft.WinGet.Client.Engine/Helpers/WinGetCLICommandBuilder.cs
Outdated
Show resolved
Hide resolved
src/PowerShell/Microsoft.WinGet.Client.Engine/Helpers/WinGetCLICommandBuilder.cs Outdated Show resolved Hide resolved
src/PowerShell/Microsoft.WinGet.Client.Engine/Helpers/WinGetCLICommandBuilder.cs
Outdated
Show resolved
Hide resolved
src/PowerShell/Microsoft.WinGet.Client.Engine/Helpers/WinGetCLICommandBuilder.cs Outdated Show resolved Hide resolved
AmelBawa-msft added 2 commits
January 22, 2026 15:57JohnMcPMS previously approved these changes Jan 23, 2026
AmelBawa-msft
dismissed
JohnMcPMS’s stale review
via
5b0d883
JohnMcPMS approved these changes Jan 23, 2026
AmelBawa-msft
deleted the
user/amelbawa/pwsh-fix
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants