Supports missing request body parameter by MIchaelMainer · Pull Request #284 · microsoftgraph/MSGraph-SDK-Code-Generator

Merged

MIchaelMainer merged 2 commits intodevfrom

MIchaelMainer/fixMethodRequestBody

Sep 8, 2020

Merged

Supports missing request body parameter#284
MIchaelMainer merged 2 commits intodevfrom
MIchaelMainer/fixMethodRequestBody

Conversation

Copy link Copy Markdown

Collaborator

MIchaelMainer commented
Sep 5, 2020

CSDL reordering triggered this regression. Discovered that reordered overloaded action, evaluateDynamicMembership was missing a property. We were only capturing parameters for the first overload. We need to capture all of the parameters which this commit fixes.

MIchaelMainer added 2 commits

September 4, 2020 22:55

Supports missing request body parameter

247e10d

Discovered that reordered overloaded action, evaluateDynamicMembership
exposed that we were only capturing parameters for the first overload.
We need to capture all of the parameters which this commit fixes.

Remove unused comments

aed1b8e

MIchaelMainer requested review from baywet, nikithauc and zengin

September 5, 2020 06:45

nikithauc approved these changes Sep 8, 2020

View reviewed changes

baywet reviewed Sep 8, 2020

View reviewed changes

src/GraphODataTemplateWriter/Extensions/OdcmModelExtensions.cs

		/// <returns>A deduplicated list of OdcmParameter.</returns>
		public static List<OdcmParameter> WithDistinctParameters(this OdcmMethod odcmMethod)
		{
		var distinctMethods = odcmMethod.WithDistinctOverloads();