feature/odata cast derivedconstraint by baywet · Pull Request #303 · microsoftgraph/MSGraph-SDK-Code-Generator
Conversation
zengin
left a comment
•
Loading
zengin
left a comment
•
Loading
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E2E logic makes sense.
Waiting on:
- Are return type changes breaking?
- Decision from microsoft/Vipr#147 (comment), in case it requires changes in this repository.
@zengin thanks for the great feedback! replied to both.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- tests need the same updates
- tests need the same updates
yep, I just saw that, on it :)
@zengin I actually had forgotten a file in my last commit 🤦♂️
baywet
deleted the
feature/odata-cast-derivedconstraint
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters