bugfix/singlevalueextendedproperties deserialization by baywet · Pull Request #497 · microsoftgraph/msgraph-sdk-java

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@baywet

Copy link Copy Markdown

Member

@baywet baywet commented

Sep 23, 2020

fixes #475

Note: In this PR you'll see that I'm removing the propertyName@odata.nextlink parsing. That is because it was passed to the response object and then never used. On top of that the builder was never instanciated (where the next link should be passed) and that's because the client is not available in the entity class.

Copy link Copy Markdown

Collaborator

@MIchaelMainer MIchaelMainer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the generator changes.

@baywet baywet merged commit cae2685 into dev

Sep 23, 2020

@baywet baywet deleted the bugfix/singlevalueextendedproperties-deserialization branch

September 23, 2020 22:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MIchaelMainer MIchaelMainer MIchaelMainer approved these changes

@zengin zengin Awaiting requested review from zengin

@nikithauc nikithauc Awaiting requested review from nikithauc

Assignees

@baywet baywet

Labels

None yet

Projects

None yet

Milestone

2.3.0

Development

Successfully merging this pull request may close these issues.

Error deserializing singleValueExtendedProperties for Event

2 participants

@baywet @MIchaelMainer