Allow empty header and footer by tandrewnichols · Pull Request #160 · miickel/gulp-angular-templatecache
Navigation Menu
{{ message }}
miickel / gulp-angular-templatecache Public
- Notifications You must be signed in to change notification settings
- Fork 103
Merged
Allow empty header and footer#160
simonua merged 1 commit intomiickel:masterfrom
Allow empty header and footer#160
simonua merged 1 commit intomiickel:masterfrom
Conversation
Copy link
Contributor
tandrewnichols
commented
Oct 11, 2018
tandrewnichols
commented
Use "in" instead of "||" since empty string is falsy
simonua
self-requested a review
Copy link
Collaborator
simonua
commented
Oct 11, 2018
simonua commented
Oct 11, 2018@tandrewnichols, thank you very much for the PR and the added test within the PR! Using in is advantageous here, I agree.
simonua approved these changes Oct 11, 2018
simonua
closed this
simonua
reopened this
simonua
merged commit
1a28e23
into
miickel:master
tandrewnichols
deleted the
empty-header-footer
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants